Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deploy script to use environment variables #199

Closed
anthmatic opened this issue Jun 23, 2020 · 2 comments · Fixed by #231
Closed

Update deploy script to use environment variables #199

anthmatic opened this issue Jun 23, 2020 · 2 comments · Fixed by #231
Assignees
@jasonnrosa
Labels
enhancement Improves upon an existing feature

Comments

@anthmatic
Copy link
Contributor

With the addition of HubSpot/hubspot-cli#118, you can now pass config values as environment variables instead of creating a config file, which would simplify deployment
@jasonnrosa jasonnrosa added the enhancement Improves upon an existing feature label Jun 23, 2020
@williamspiro
Copy link
Contributor

HubSpot/hubspot-cli#270 would be 🆒 as well

@jasonnrosa jasonnrosa self-assigned this Sep 21, 2020
@jasonnrosa jasonnrosa mentioned this issue Sep 21, 2020
Merged
6 tasks
@jasonnrosa
Copy link
Member

Update - we should switch over to the new HubSpot CMS deploy action. Documentation here: (https://github.com/marketplace/actions/hubspot-cms-deploy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonnrosa jasonnrosa

Labels
enhancement Improves upon an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing generate config file in favor of GitHub secrets HubSpot/cms-theme-boilerplate
3 participants
@anthmatic @jasonnrosa @williamspiro