Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension .eot not supported #399

Closed
th0rgall opened this issue Dec 10, 2020 · 1 comment · Fixed by #484
Closed

File extension .eot not supported #399

th0rgall opened this issue Dec 10, 2020 · 1 comment · Fixed by #484
Assignees
Labels
enhancement New feature or request

Comments

@th0rgall
Copy link

th0rgall commented Dec 10, 2020

Description and Context

I got a weird problem in my HS project: .eot font files didn't get uploaded to my theme, throwing this error:

[ERROR] The file "sr-theme-customized/fonts/suisse-intl/SuisseIntl-Black-WebS.eot" does not have a valid extension

Steps to reproduce

Upload a file with the .eot extension using hs upload.

What I tried

I made a fork and tried to add eot to the ALLOWED_EXTENSIONS list, see here https://github.com/th0rgall/hubspot-cms-tools/pull/1/files#diff-c360fc5df10a4024db0e2534d8de43092761d7a1e2805bac489a5a76e25fdc19R20

I assume this "passes" the eot file through the client-side CLI validations for files. But when I tested this change, I got a different error

[ERROR] Failed to process file /<omitted>/sr-theme-customized/fonts/suisse-intl/SuisseIntl-Black-WebS.eot. File extension 'eot' is not supported

Since I didn't see any other references to allow lists in the CLI client code, I assume this is a HubSpot server validation error, which I'm not able to fix.

Expected behavior

Allow fonts with the .eot extension to be uploaded.

@anthmatic anthmatic self-assigned this Feb 25, 2021
@anthmatic
Copy link
Contributor

@th0rgall I'm looking into adding support for these files. I'll check back here when I have an update.

@brandenrodgers brandenrodgers added the enhancement New feature or request label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants