Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to include cube map reflections for any and all models that are using PBR shader. #406

Closed
j-conrad opened this issue May 25, 2018 · 1 comment
Assignees
Labels
enhancement work that enhances an existing feature

Comments

@j-conrad
Copy link
Contributor

j-conrad commented May 25, 2018

Any models that use the PBR shader and have roughness that is anything less than 100% need something to reflect. Without reflection maps, any shiny objects will appear way too dark. Typically, this is done by having a cubic or spherical reflections. Ideally, this would be generated by placing nodes within the environment and having part of the build process generate reflection maps at those locations. You'd also want to be able to specify the distance (a depth defined by x, y, z--a box, essentially) that the reflection maps would render. Then, those reflection maps would get applied to any and all PBR materials in your scene. See Unity's documentation on Reflection Probes for what I'm describing here. https://docs.unity3d.com/Manual/class-ReflectionProbe.html
In lieu of this auto-generation, I would settle for the ability to set one reflection map for a given scene that would get applied to all meshes with a PBR material on them.

@j-conrad j-conrad added the enhancement work that enhances an existing feature label May 25, 2018
@robertlong
Copy link
Contributor

Closing in favor of https://github.com/MozillaReality/Spoke/issues/350 and #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants