Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK中 protocol 的判断逻辑 #3

Closed
RainSunMe opened this issue May 24, 2023 · 3 comments
Closed

SDK中 protocol 的判断逻辑 #3

RainSunMe opened this issue May 24, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@RainSunMe
Copy link

我这里服务端的协议是https
但是SDK在http
希望SDK配置api的时候可以同时设定protocol，而不是直接从document.currentScript?.baseURI拿
@RainSunMe
Copy link
Author

我理解使用document.currentScript?.baseURI的意思是想要读引入script的url？

<script
      crossorgin="anonymous"
      src="https://exp.com/page-spy/index.min.js"
    ></script>

但是实际上拿到的是new PageSpy所在代码块的url

@wqcstrong
Copy link
Collaborator

感谢反馈，的确存在这个问题，我调整一下

@wqcstrong wqcstrong added the good first issue Good for newcomers label May 24, 2023
@wqcstrong wqcstrong mentioned this issue May 24, 2023
Merged
@wqcstrong
Copy link
Collaborator

问题已修复

@wqcstrong wqcstrong added the bug Something isn't working label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wqcstrong @RainSunMe