Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage ignores .coveragerc #883

Closed
lmshk opened this issue Sep 21, 2017 · 1 comment · Fixed by #886
Closed

Coverage ignores .coveragerc #883

lmshk opened this issue Sep 21, 2017 · 1 comment · Fixed by #886
Labels
bug something is clearly wrong here

Comments

@lmshk
Copy link

lmshk commented Sep 21, 2017

Upgrading hypothesis beyond 3.29.0 broke our test setup: apparently, hypothesis now interferes with coverage and makes it ignore .coveragerc, causing lots of entries in the coverage report and violating --fail-under=100. (The entries now include missed paths in installed packages and in Python itself.)

(Also, the upgrade tripled test running time and caused deprecation warnings of the type "test took too long"; possibly related: #879.)

Versions:

  • Python: 3.6.2
  • hypothesis: 3.30.0
  • coverage: 4.4.1
  • (virtualenv: 15.1.0)

Setting use_coverage to False fixed these issues.

@DRMacIver
Copy link
Member

Whoops, sorry! Ignoring coveragerc for our own internal usage is intended behaviour, but it certainly shouldn't be propagating excluded paths back to the enclosing coverage. That's pretty bad. I'll try to get a fix out in the next couple of days.

@Zac-HD Zac-HD added the bug something is clearly wrong here label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is clearly wrong here
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants