Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify data overview screens and remove references to "missing" unpopulated fields #1550

Closed
emmajclegg opened this issue Sep 10, 2024 · 15 comments · Fixed by #1593
Closed
Assignees
Labels
ODS Issue initiated by ODS Support

Comments

@emmajclegg
Copy link
Collaborator

emmajclegg commented Sep 10, 2024

User story: As someone entering data in IATI Publisher, I want data overview screens to show me clearly a) what information I have entered, and b) if there are any mandatory fields missing

User issues:

  • From support queries, we know that displaying the word "missing" on the overview screens makes some users think that they have to go back and populate these fields, which is not true if they are optional
  • The extra text clutters the interface - a blank space would equally communicate that the field is unpopulated and make it clearer for users to see the information that they have populated so far.

Image

Suggested action:
Can we review the overview screens for transaction, result and indicator initially.

  1. to focus on information that the user has populated, rather than showing them all possible data fields (most of which will be unpopulated). At minimum, they shouldn't see all the unpopulated fields for document-link in the screenshot above, when this is a nested element that hasn't been used
  2. to remove the word "missing" when a data field is unpopulated, unless this can be applied only to mandatory fields

This is related to, and should complement, the review of data entry forms #1553

@emmajclegg emmajclegg added ODS Issue initiated by ODS Support labels Sep 10, 2024
@emmajclegg emmajclegg changed the title Remove "missing" wording for unpopulated fields on data overview screens Simplify data overview screens and remove references to "missing" unpopulated fields Sep 18, 2024
@asminashrestha
Copy link
Collaborator

asminashrestha commented Sep 25, 2024

Hi @emmajclegg You can view the updated designs here: Sub-elements missing case
Baseline missing case
Document Link missing case

@BibhaT
Copy link
Collaborator

BibhaT commented Sep 25, 2024

Hi @emmajclegg , are we good to move forward with the development here?

@emmajclegg
Copy link
Collaborator Author

Thanks @asminashrestha - I've added a few comments on the three Figma designs you've linked above.

I think the light grey text for unpopulated fields looks a lot better in the interface, though am double-checking with someone in ODS whether there's any user accessibility concerns before we go ahead and implement (cc' @BibhaT)

Similar to how data entry form changes will need to be applied across IATI Publisher in one go, will the changes in this issue affect all overview screens (e.g. ones on the Activity Data page shown below)?

image

@emmajclegg
Copy link
Collaborator Author

emmajclegg commented Sep 26, 2024

@asminashrestha - to update on the user accessibility point:

For context, ODS will likely do full accessibility reviews of all IATI tools (including IATI Publisher) at some point, though probably not this year. Among other things, this will be to make sure the tools are accessible for people with visual impairments who use a screen reader. The translated French/Spanish interface work is another example.

In this case of data overview screens, the use of light grey text is not judged accessible from a visual readability point of view. The alternatives that have been suggested to me to separate out populated from unpopulated fields are:
a) Replace the light grey "N/A" with empty space (i.e. no text), or
b) List unpopulated fields, rather than trying to display a value for them - i.e something like the section highlighted green below:

Image

I'll take your steer on which of these approaches is easier to implement, but it's worth making the changes now rather than having to redo work in future.

Any questions, let me know (tomorrow - Friday - is my last day before a week's leave)

@BibhaT
Copy link
Collaborator

BibhaT commented Sep 27, 2024

Similar to how data entry form changes will need to be applied across IATI Publisher in one go, will the changes in this issue affect all overview screens (e.g. ones on the Activity Data page shown below)?

This is all FrontEnd work and the structure is different from that on the BackEnd. These changes will have to be done one element at a time and won't affect another element's/activity detail view.

@asminashrestha
Copy link
Collaborator

Hi @emmajclegg We reviewed the options you suggested and reconsidered the color for the "N/A" label. We feel that the best option is to use a darker color for "N/A" to ensure there are no accessibility issues. Please take a look and let us know your thoughts. View Link
Also, regarding the "Language: English" label, we had a short discussion over it, We feel that further detailed discussion is needed before making a decision. We suggest that we treat this as a separate issue for now. Is that okay?

@emmajclegg
Copy link
Collaborator Author

Hi @asminashrestha - yes, both of those points sound fine to me. Feel free to go ahead with the development work on this issue.

@Yash-ftW Yash-ftW self-assigned this Sep 30, 2024
@PG-Momik PG-Momik assigned Sanam-07 and unassigned Yash-ftW Oct 17, 2024
@Yash-ftW Yash-ftW assigned Yash-ftW and Sanam-07 and unassigned Sanam-07 and Yash-ftW Oct 21, 2024
@Yash-ftW
Copy link
Collaborator

@emmajclegg , This has been deployed to staging.

@Yash-ftW Yash-ftW assigned emmajclegg and unassigned Sanam-07 Oct 22, 2024
@emmajclegg
Copy link
Collaborator Author

emmajclegg commented Oct 22, 2024

Thanks @Yash-ftW - can I confirm how widely these changes have been applied? (i.e. which interface pages have changed)

I see changes on the Indicator Detail and Period Detail pages for example, but mentioned that I'm no longer seeing changes to the location element overview in this issue (#1559), so want to check

@Yash-ftW
Copy link
Collaborator

Hi @emmajclegg, The changes are for Indicator, Period and Transaction element.

but mentioned that I'm no longer seeing changes to the location element overview in this issue (#1559)

The location changes are on other issue. Both changes have been deployed to staging now.

@emmajclegg
Copy link
Collaborator Author

Ok @Yash-ftW - for consistency, can the Period Detail screen be checked as there still seems to be full document-link information showing even if the user has not populated anything for this sub-element:

image

This nested element detail no longer appears on the Result and Indicator Detail screens (which is good, as it detracts from the more important information on these overview screens).

For remaining "missing" labels against unpopulated fields - let's wait and replace these (with "N/A" or otherwise) once the automated text extraction and reintegration process is in place (task #1477). This will be quicker than continuing to manually update text in different parts of the interface

@Yash-ftW Yash-ftW assigned Yash-ftW and Sanam-07 and unassigned emmajclegg and Yash-ftW Oct 24, 2024
@Yash-ftW
Copy link
Collaborator

Thankyou @emmajclegg, I've changed for the Period interface as well, and has been deployed to staging. Please review it and let me know if any changes are to be done.

@emmajclegg
Copy link
Collaborator Author

emmajclegg commented Oct 24, 2024

@Yash-ftW - one remaining inconsistency I've noticed:

Mandatory sub-elements are marked with yellow core rings on the transaction detail page, whereas the same concept is marked with red asterisks on the result and indicator detail pages. Provided these are marking the same thing, can we please be consistent and use the red asterisks to avoid user confusion:

Image

Once this change is made, I'm happy for the changes in this issue to be deployed.

@emmajclegg emmajclegg assigned Yash-ftW and unassigned emmajclegg Oct 24, 2024
@Yash-ftW
Copy link
Collaborator

Hi @emmajclegg, The change has been made and deployed to staging. Please review it and let me know if any more changes are to be done.

@Yash-ftW Yash-ftW assigned emmajclegg and unassigned Yash-ftW Oct 25, 2024
@emmajclegg
Copy link
Collaborator Author

I've reviewed and happy for this to be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ODS Issue initiated by ODS Support
Projects
None yet
5 participants