-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Yarn's --exclude
#298
Comments
I was not aware of this. Absolutely, I would support passing this argument. One point of debate is whether we should just go ahead and have some approach of passing in extra arguments directly to auditors vs. making an --exclude flag. Making a Yarn-exclusive flag would be a first. Perhaps we can have an --extra-arguments flag which would append whatever is provided to the underlying auditor directly. |
This sounds like a good idea to me. Happy to start a PR this week |
chore(deps): bump json5 from 1.0.1 to 1.0.2 (IBM#299) Add --extra-args to fix IBM#298 (IBM#300) Signed-off-by: Quinn Turner <[email protected]>
Certain dependencies will cause NPM's quick audit endpoint to return a 400 Bad Request error, which bubbles up to
yarn npm audit
failing with that error andaudit-ci
failing with an "Invalid JSON" error.Normally, we can work around this with
yarn npm audit --exclude <pkg>
, but currently there's no way to pass such excludes to Yarn when running it withaudit-ci
.Would an "exclude" feature in audit-ci be acceptable? If so, I can start working on a PR.
The text was updated successfully, but these errors were encountered: