IBM Z Open editor: Expand source code doesn't work for URI's

[TommyTechh]

Describe the bug
Expand source code seemingly only works for local files on disk and not the new in-memory files

To Reproduce
Steps to reproduce the behavior:

Open any file through zowe explorer v3+ and wait for copybooks to be fetched.
Use the IBM Z Open editor: Expand source code command.

And a error is thrown:
CRRZG5297E COBOL source could not be expanded. Check the Z Open Editor or COBOL Language Server log files for more details.
When opening the vscode Z Open Editor output log the same error is shown.

Expected behavior

Be able to expand source that is a shown as in-memory files from zowe explorer

Desktop (please complete the following information):

OS: Windows 11 23H2
Zowe Explorer Version: v3.0.3
(Optional) Zowe CLI Version:
(Optional) Are you using Secure Credential Store?:

Additional context

[TommyTechh]

Hi @phaumer,

We're very interested in this function as we utilize expanded source code to run different unit tests. We currently have our own custom expander, but would be more than interested in using the one that you guys provide. In our own custom expander we've had to have custom logic on CICS expressions such as DFHVALUE(), DFHRESP() and EIBTRNID.

Can you shed some light on your future plans for this function in the Z open editor if there are any?

Perhaps this question should be in the discussion section?

Thanks in advance

[phaumer]

@TommyTechh thanks. These are great ideas, which I will add to our list. In these public forums we are not allowed to commit to specific features and timelines. So I can only say that we are very interested in improving this functionality and there were already other request here for supporting conditional compilation as well. Those custom logic expression expansions sound very useful to add. Feel free to start a discussion thread in this repo so other users can chip in providing their requirements.

[TommyTechh]

@phaumer Awesome to hear!

I will be noting down feature requests for the function in this thread moving forward.

For starters:
It would be ideal that the expander does not expand unless the copybooks have been resolved/found. Either it should throw an error or wait for the copybook resolving to finish. Currently, the expanding command will open a new "expanded" file when called, but the file will simply be a complete copy of the original file because the copybook resolving hasn't finished.

[stewartfrancis]

@TommyTechh I'd be interested in hearing your use-case for expanding DFHVALUE DFHRESP and similar, and details of how your custom logic handles them.

[phaumer]

We fixed expanding files loaded via Zowe Explorer in v5.2.0.

I am closing this issue, but extracted the CICS request to #477 @TommyTechh and @stewartfrancis .