Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring constant calculation broken #38

Closed
srmnitc opened this issue Aug 5, 2022 · 0 comments · Fixed by #39
Closed

Spring constant calculation broken #38

srmnitc opened this issue Aug 5, 2022 · 0 comments · Fixed by #39
Labels
bug Something isn't working

Comments

@srmnitc
Copy link
Member

srmnitc commented Aug 5, 2022

Spring constant calculation does not work because https://github.com/ICAMS/calphy/blob/master/calphy/solid.py#L240 checks a single value for None, while spring constants can be list.
@srmnitc srmnitc added the bug Something isn't working label Aug 5, 2022
@srmnitc srmnitc mentioned this issue Aug 5, 2022
Closed
@srmnitc srmnitc linked a pull request Aug 5, 2022 that will close this issue
Fix issues with spring constant and add validation #39
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with spring constant and add validation ICAMS/calphy
1 participant
@srmnitc