Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for climatic_summary when there's no summaries provided #71

Open
dannyparsons opened this issue Mar 4, 2022 · 0 comments
Open

Comments

@dannyparsons
Copy link
Contributor

@HawardKetoyoMsatsi Lily found a bug here #67 which wasn't picked up by the tests I had written because I didn't include a test example where the summaries parameter is not provided e.g. this example below.

climatic_summary(data = daily_niger, date_time = "date", station = "station_name",
                              elements = c("rain", "tmax"))

Could you add a test for this case? It can be any call to climatic_summary where summaries is not provided. In this case, it uses the default summary which is dplyr::n().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant