Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug: datav1.py] The loaded semantic labels are bugged #18

Open
GregorKobsik opened this issue Mar 29, 2023 · 0 comments
Open

[Bug: datav1.py] The loaded semantic labels are bugged #18

GregorKobsik opened this issue Mar 29, 2023 · 0 comments

Comments

@GregorKobsik
Copy link

GregorKobsik commented Mar 29, 2023

Description:

I suppose, that the code in datav1.py has a bug in line 572. The returned semantic labels are a concatenation of all parent node labels down to the leaf node. This results in errors in the visualization script vis_pc.ipynb, especially in vis_utils.py in function draw_partnet_objects(...) in line 240 color = sem_colors[part_sems[jj]

Solution:

node.full_label = parent.full_label + '/' + node.label

You can fix it by replacing the code with:
node.full_label = node.label

Example (Object #2197):

Current output

['chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_seat/chair/chair_seat/seat_surface/chair/chair_seat/seat_surface/seat_single_surface', 'chair/chair/chair_seat/chair/chair_seat/seat_support', 'chair/chair/chair_arm/chair/chair_arm/arm_sofa_style', 'chair/chair/chair_arm/chair/chair_arm/arm_sofa_style', 'chair/chair/chair_back/chair/chair_back/back_surface/chair/chair_back/back_surface/back_single_surface', 'chair/chair/chair_back/chair/chair_back/back_surface/chair/chair_back/back_surface/back_single_surface', 'chair/chair/chair_back/chair/chair_back/back_support']

Expected output (after fix)

['chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_seat/seat_surface/seat_single_surface', 'chair/chair_seat/seat_support', 'chair/chair_arm/arm_sofa_style', 'chair/chair_arm/arm_sofa_style', 'chair/chair_back/back_surface/back_single_surface', 'chair/chair_back/back_surface/back_single_surface', 'chair/chair_back/back_support']

Can anyone confirm this bug, too?

@GregorKobsik GregorKobsik changed the title [Bug: Data Loader] The loaded semantic labels are bugged [Bug: datav1.py] The loaded semantic labels are bugged Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant