From 90f8a75fc10066be9e8c5034a10784feff7da776 Mon Sep 17 00:00:00 2001 From: Quyen Ly Date: Tue, 14 Mar 2023 12:58:22 +0700 Subject: [PATCH] FRI-621 Truncate the full component text if it's too long while creating JIRA ticket for RVF failures --- .../service/RVFFailureJiraAssociationService.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/ihtsdo/buildcloud/core/service/RVFFailureJiraAssociationService.java b/src/main/java/org/ihtsdo/buildcloud/core/service/RVFFailureJiraAssociationService.java index eafdf0719..0a05b127f 100644 --- a/src/main/java/org/ihtsdo/buildcloud/core/service/RVFFailureJiraAssociationService.java +++ b/src/main/java/org/ihtsdo/buildcloud/core/service/RVFFailureJiraAssociationService.java @@ -154,7 +154,7 @@ private String generateDescription(Build build, ValidationReport.RvfValidationRe List firstNInstances = getFirstNInstances(testRunItem.getFirstNInstances(), 10); result += "First " + firstNInstances.size() + " failures: \n"; for (ValidationReport.RvfValidationResult.TestResult.TestRunItem.FailureDetail failureDetail: firstNInstances) { - result += "* " + failureDetail.toString() + "\n"; + result += "* " + failureDetail.toStringAndTruncateIfTextTooLong() + "\n"; } return result; @@ -328,6 +328,7 @@ public String toString() { } private static final class FailureDetail { + private static final int FULL_COMPONENT_MAX_LENGTH = 1000; private String conceptId; private String conceptFsn; private String detail; @@ -364,6 +365,16 @@ public String toString() { "\"fullComponent\": " + (fullComponent != null ? '\"' + fullComponent + '\"' : null) + "\n" + "}"; } + + public String toStringAndTruncateIfTextTooLong() { + return "{\n\t" + + "\"conceptId\": " + (conceptId != null ? '\"' + conceptId + '\"' : null) + ",\n\t" + + "\"conceptFsn\": " + (conceptFsn != null ? '\"' + conceptFsn + '\"' : null) + ",\n\t" + + "\"detail\": " + (detail != null ? '\"' + detail + '\"' : null) + ",\n\t" + + "\"componentId\": " + (componentId != null ? '\"' + componentId + '\"' : null) + ",\n\t" + + "\"fullComponent\": " + (fullComponent != null ? '\"' + (fullComponent.length() <= FULL_COMPONENT_MAX_LENGTH ? fullComponent : fullComponent.substring(0, FULL_COMPONENT_MAX_LENGTH)) + "..." + '\"' : null) + "\n" + + "}"; + } } } }