Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify viewer demos to use canonical JSON and viewer-specific translation snippet (make issue per viewer) #25

Closed
5 tasks done
JulieWinchester opened this issue May 3, 2023 · 8 comments

Comments

@JulieWinchester
Copy link
Contributor

JulieWinchester commented May 3, 2023

We need forks of code sandboxes for the individual demos in the viewer demo documentation modified to use our common JSON label annotations.

  • Aleph
  • Google Model Viewer
  • Sketchfab
  • Smithsonian Voyager
  • X3D
@gjcope
Copy link

gjcope commented May 11, 2023

Voyager demo fork is here: https://codesandbox.io/s/voyager-annotations-demo-forked-rqivl4?file=/index.html

Main adjustment was aligning attribute names.

@edsilv
Copy link
Contributor

edsilv commented May 12, 2023

Sketchfab demo: https://codesandbox.io/s/sad-lena-b39r00?file=/src/index.js

@edsilv
Copy link
Contributor

edsilv commented May 12, 2023

Google model-viewer demo: https://codesandbox.io/s/model-viewer-annotations-demo-3k5tqo

@edsilv
Copy link
Contributor

edsilv commented May 12, 2023

modelviewer annos pasted into sketchfab:
8CF8C450-1A15-47ED-ADAA-829DB597B614

sketchfab annos pasted into modelviewer:
6A89C632-7F9D-4A75-A65A-258EC8A1E481

@gjcope any chance you could add a text field under Voyager to copy/paste annotation json into/out of?

@JulieWinchester
Copy link
Contributor Author

Aleph demo: https://codesandbox.io/s/aleph-annotation-demo-common-annotation-json-8rbos9

I also added a text field similar to what the Model Viewer demo uses to allow for interactive experimentation with annotation JSON.

@edsilv
Copy link
Contributor

edsilv commented May 17, 2023

Tried copying/pasting annotations between the aleph and modelviewer demos and they appear in their correct locations.

@vincentmarchetti
Copy link
Contributor

have modified the X3D viewer to read annotations from a local copy of the canonical json at https://github.com/IIIF/3d/blob/main/demo/json/label-annotation-issue-17.json at commit c353301

X3D demo is at
https://codesandbox.io/p/github/vincentmarchetti/x3d-remote-annotation

@JulieWinchester
Copy link
Contributor Author

This task and this project have been successfully completed, good work all! Thanks to everyone for all of the effort and great results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants