-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify viewer demos to use canonical JSON and viewer-specific translation snippet (make issue per viewer) #25
Comments
Voyager demo fork is here: https://codesandbox.io/s/voyager-annotations-demo-forked-rqivl4?file=/index.html Main adjustment was aligning attribute names. |
Sketchfab demo: https://codesandbox.io/s/sad-lena-b39r00?file=/src/index.js |
Google model-viewer demo: https://codesandbox.io/s/model-viewer-annotations-demo-3k5tqo |
modelviewer annos pasted into sketchfab: sketchfab annos pasted into modelviewer: @gjcope any chance you could add a text field under Voyager to copy/paste annotation json into/out of? |
Aleph demo: https://codesandbox.io/s/aleph-annotation-demo-common-annotation-json-8rbos9 I also added a text field similar to what the Model Viewer demo uses to allow for interactive experimentation with annotation JSON. |
Tried copying/pasting annotations between the aleph and modelviewer demos and they appear in their correct locations. |
have modified the X3D viewer to read annotations from a local copy of the canonical json at https://github.com/IIIF/3d/blob/main/demo/json/label-annotation-issue-17.json at commit c353301 X3D demo is at |
This task and this project have been successfully completed, good work all! Thanks to everyone for all of the effort and great results. |
We need forks of code sandboxes for the individual demos in the viewer demo documentation modified to use our common JSON label annotations.
The text was updated successfully, but these errors were encountered: