Should we drop Qt 4.8 compatibility?

[jounathaen]

In the Github Project description it says, that QtPass requires Qt4.8 or higher. I noticed for example that the code consists of several of QStringLiteral which is - according to https://woboq.com/blog/qstringliteral.html - a QT5 Feature. So maybe the Qt4.8 compatibility should be removed from the project description

[annejan]

I have not checked recently but before the 1.0 release for all the Qt5 stuff there was a Qt4 fallback.

I'm giving this (building on Qt 4.8.6) a try and see if building fails I'll see what we can do, might go either way (updating site / README) or "fixing" the app ;-)

[annejan]

Turns out QtPass was compatible with Qt4.8 until just now . .
I had travis running a Qt 4.8.1 build since . . forever . . so I changed the title of this issue

But a very recent change I just literally now merged to master breaks qt4 compatibility.
https://travis-ci.org/IJHack/qtpass/jobs/105755073

Implemented a (neat) work-around . . again
https://travis-ci.org/IJHack/qtpass/jobs/106002053 back to Qt 4.8 compatibility . .
Since a clear button is not 'necessary' for the use of the app . .

[annejan]

Might re-open when this comes up again ;)

Will keep (minimal) Qt4.8 compatibility since it is still used a lot in distro's . .

[annejan]

I should probably setup CI for 4.8 if we want to keep it on . .