Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

604 deaccession dataset #611

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Feb 26, 2025

What this PR does / why we need it:

Implements the Deaccession Dataset feature

Which issue(s) this PR closes:

Special notes for your reviewer:

When users choose multiple versions to Deaccession, there are multiple asynchronous calls to the API, one for each version. This is causing an intermittent test failure in DeaccessionDatasetButton.spec.tsx. Is there another way to make these API calls to avoid this?

Suggestions on how to test this:

Step 1: Run the Development Environment

Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.

Step 2: Test the feature

  1. Create a dataset and publish it
  2. From the Edit Dataset drop down, choose Deaccession Dataset
  3. Fill out the form and click 'Continue'
  4. On the confirm modal, click 'Yes'
  5. The Deaccession should be successful, and the Dataset Page will show that the Dataset has been deaccessioned.
  6. Create another dataset, and publish multiple versions of the Dataset
  7. From the Edit Dataset drop down, choose Deaccession Dataset
  8. Check that all the published versions are displayed
  9. Choose multiple versions and check that they are all deaccessioned.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Replicating these JSF UI Components:
Screenshot 2025-03-07 at 1 15 19 PM
Screenshot 2025-03-07 at 1 14 22 PM
Screenshot 2025-03-07 at 1 15 00 PM

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller changed the title Feat/604 deaccession dataset 604 deaccession dataset Feb 26, 2025
@coveralls
Copy link

coveralls commented Feb 26, 2025

Coverage Status

coverage: 97.754%. remained the same
when pulling f908181 on feat/604-deaccession-dataset
into 64ab9a7 on develop.

@ekraffmiller ekraffmiller marked this pull request as ready for review March 7, 2025 18:35
@ekraffmiller ekraffmiller added FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) SPA.Q1.5 Dataset Page: Deaccession Dataset Size: 10 A percentage of a sprint. 7 hours. Original size: 10 SPA: Dataset page (View) labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Dataset page (View) SPA.Q1.5 Dataset Page: Deaccession Dataset
Projects
Status: Ready for Review ⏩
Development

Successfully merging this pull request may close these issues.

Deaccession Dataset Integration
2 participants