Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with service specifications #3212

Closed
GitHK opened this issue Jul 22, 2022 · 2 comments
Closed

Issue with service specifications #3212

GitHK opened this issue Jul 22, 2022 · 2 comments
Assignees

Comments

@GitHK
Copy link
Contributor

GitHK commented Jul 22, 2022

If I setup and entry inside services_specifications which overwrites the memory and CPU limits, like the following CSV:

service_key,service_version,gid,sidecar
simcore/services/dynamic/jupyter-smash,3.0.7,2,"{""TaskTemplate"": {""Resources"": {""Limits"": {""NanoCPUs"": 4000000000, ""MemoryBytes"": 43687091200}}}}"

The following happens:

  1. The dynamic-sidecar has its limits set to what is specified above (overwrite OK)
  2. The created container running the jupyter-smash has the original limit (not overwritten)

Conclusions after investigation

  • The webserver fetches the information regarding he limits from the catalog via the service resources endpoint (catalog) and passes down the information to the director-v2 who uses it to start the service.
  • Clearly the service specifications endpoint (catalog) is used and the data is injected to the dynamic-sidecar when the service is started and overwrites the information about the resources coming from the webserver.
  • The service specifications are only applied to the dynamic-sidecar.

Questions

  • Should the service specifications also apply to the containers created by the dynamic sidecar? ( I guess no since these are mainly used as placement constraints and it was never intended to be used as showcased above)
  • To obtain what I want to do above, I guess the webserver should inject the changed values as discussed prior to this.

@sanderegg care to elaborate more on this topic and what was the original goad and what it should be able to do or not to do.

@GitHK GitHK added the bug buggy, it does not work as expected label Jul 22, 2022
@sanderegg
Copy link
Member

sanderegg commented Jul 23, 2022

@GitHK : this is not a bug. This has never been implemented due to lack of resources. You can only override the dy-sidecar specifications as per design. The rest of that feature (ITISFoundation/osparc-issues#618) will come once resources are freed to do so.

I think you may therefore close this bug .

@GitHK GitHK removed the bug buggy, it does not work as expected label Sep 6, 2022
@GitHK
Copy link
Contributor Author

GitHK commented Sep 6, 2022

I agree this is not a bug. Closing

@GitHK GitHK closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants