fix(core): don't dispose env because it happens to early

for now it won't cause any issues, because existing workflow will free resources when initial host process is terminated
Igmat · Mar 7, 2018 · ef3b5fa · ef3b5fa
1 parent 36b9103
commit ef3b5fa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/baset-core/src/testGroup.ts b/packages/baset-core/src/testGroup.ts
@@ -103,7 +103,9 @@ export class TestGroup {
             : new Promise<string>(resolve => resolve(''));
 
         const output = await this.baseliner.compare(testsResults, baselineValue);
-        this.environment && this.environment.dispose();
+        // FIXME: find out why next disposal happens before result are calculated
+        // after test proccess termination server is stopped, so it's not an issue now
+        // this.environment && this.environment.dispose();
 
         return {
             path: baselinePath,

diff --git a/packages/baset-env-browser/src/index.ts b/packages/baset-env-browser/src/index.ts
@@ -1,7 +1,7 @@
 import { AbstractEnvironment, utils } from 'baset-core';
 import express from 'express';
-import path from 'path';
 import { Server } from 'http';
+import path from 'path';
 
 export interface IBrowserEnvOptions {
     staticFolder?: string;