From 784a1a5ba18b84c45621e38fba5aa0819d8e4dd9 Mon Sep 17 00:00:00 2001 From: Simeon Simeonoff Date: Wed, 22 Nov 2023 17:03:19 +0200 Subject: [PATCH] refactor(avatar,icon): update default sizes (#133) Revert some of the sizes to not introduce visual breaking changes in Ignite UI for Angular. --- .../schemas/components/light/_avatar.scss | 19 ++++--------------- .../schemas/components/light/_icon.scss | 4 ++-- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/sass/themes/schemas/components/light/_avatar.scss b/sass/themes/schemas/components/light/_avatar.scss index 0ee6092c..1f8d8916 100644 --- a/sass/themes/schemas/components/light/_avatar.scss +++ b/sass/themes/schemas/components/light/_avatar.scss @@ -13,7 +13,7 @@ /// @prop {Map} color [color: ('gray', 800, .96)] - The text/icon color of the avatar. /// @prop {Number} border-radius [rem(8px)] - The border radius for rounded avatar. /// @prop {List} size [(rem(40px), rem(64px), rem(88px))] - The size used for the avatar width and height. -/// @prop {Number} default-size [2] - The default size used for the avatar component. +/// @prop {Number} default-size [1] - The default size used for the avatar component. $light-avatar: ( background: ( color: ( @@ -37,19 +37,14 @@ $light-avatar: ( rem(88px), ), ), - default-size: 2, + default-size: 1, ); /// Generates a fluent avatar schema. /// @type {Map} /// @prop {Number} default-size [1] - The default size used for the avatar component. /// @requires {Map} $light-avatar -$fluent-avatar: extend( - $light-avatar, - ( - default-size: 1, - ) -); +$fluent-avatar: $light-avatar; /// Generates a bootstrap avatar schema. /// @type {Map} @@ -74,7 +69,6 @@ $bootstrap-avatar: extend( ), ), border-radius: rem(4px), - default-size: 1, ) ); @@ -82,9 +76,4 @@ $bootstrap-avatar: extend( /// @type {Map} /// @prop {Number} default-size [1] - The default size used for the avatar component. /// @requires {Map} $light-avatar -$indigo-avatar: extend( - $light-avatar, - ( - default-size: 1, - ) -); +$indigo-avatar: $light-avatar; diff --git a/sass/themes/schemas/components/light/_icon.scss b/sass/themes/schemas/components/light/_icon.scss index 0e2a1bbb..1014faf8 100644 --- a/sass/themes/schemas/components/light/_icon.scss +++ b/sass/themes/schemas/components/light/_icon.scss @@ -12,7 +12,7 @@ /// @prop {Color} color ["'currentColor'"] - The icon color. /// @prop {Color} disabled-color ["'currentColor'"] - The disabled icon color. /// @prop {List} size [(rem(18px), rem(20px), rem(24px))] - The size used for the icon. -/// @prop {Number} default-size [2] - The default size used for the icon component. +/// @prop {Number} default-size [3] - The default size used for the icon component. $light-icon: ( color: "'currentColor'", disabled-color: "'currentColor'", @@ -23,7 +23,7 @@ $light-icon: ( rem(24px), ), ), - default-size: 2, + default-size: 3, ); /// Generates a fluent icon schema.