Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdd-angular-19-changelog #1438

Merged
merged 2 commits into from
Jan 15, 2025
Merged

mdd-angular-19-changelog #1438

merged 2 commits into from
Jan 15, 2025

Conversation

mddifilippo89
Copy link
Contributor

PackageVerChanges-24-2-JAN

PackageVerChanges-24-2-JAN
@mddifilippo89 mddifilippo89 added the status: in-review 👀 PR ready for review label Jan 14, 2025
@@ -49,6 +49,7 @@
{ "name": "{PackageVerChanges-24-1-JUN}", "value": "18.0.0 (June 2024)" },
{ "name": "{PackageVerChanges-24-1-SEP}", "value": "18.1.0 (September 2024)" },
{ "name": "{PackageVerChanges-24-2-DEC}", "value": "18.2.0 (December 2024)" },
{ "name": "{PackageVerChanges-24-2-JAN}", "value": "19.0.0 (January 2025)" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "{PackageVerChanges-24-2-JAN}" variable to other platforms in this config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify, there are no other new versions. please merge

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either build flag usage of that new variable for Angular OR you must add "{PackageVerChanges-24-2-JAN}" variable to other platforms with value matching previously release version in this config because this topic is shared between all platforms and currently this variable will not be resolved to any value for Blazor, React and WC platforms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic is not shared between all platforms. Each platform has it's own topic for the changelog for this sort of reason.

@HUSSAR-mtrela HUSSAR-mtrela merged commit a7bb163 into vnext Jan 15, 2025
10 checks passed
@HUSSAR-mtrela HUSSAR-mtrela deleted the mdd-angular-19 branch January 15, 2025 10:59
@randriova randriova added the status: localized indicates that localization is complete label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in-review 👀 PR ready for review status: localized indicates that localization is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants