Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name for Forge Mod/Forge + LiteLoader files #115

Closed
browsky300 opened this issue Jan 1, 2021 · 1 comment
Closed

Incorrect name for Forge Mod/Forge + LiteLoader files #115

browsky300 opened this issue Jan 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@browsky300
Copy link

Describe the bug
When saving several versions of the Forge mod, all of them will have the name of the first one saved.

To Reproduce
Steps to reproduce the behavior:

  1. Select "Forge Mod" or "Forge + LiteLoader" from the "Install for:" dropdown menu
  2. Click "Save as"
  3. Close the Save menu
  4. Change the Impact version in the installer to any other version
  5. Click "Save as"
  6. Observe that the new file's name does not match the version selected

Expected behavior
The name of the new file matches the Impact version selected.

System Information

  • OS: Windows 10
  • Installer version: 0.9.3
  • Installer format: .exe
  • Java version: 1.8.0_271-b09

Additional context
Add any other context about the problem here.

Screenshot. Note the discrepancy in the version selected and the name.

@browsky300 browsky300 added the bug Something isn't working label Jan 1, 2021
@LeafHacker
Copy link
Contributor

In 0.9.4 the Save As dialog will always open with the "default" destination setting. This should fix your issue but could be confusing in a few edge-cases:

  • If the installer GUI is opened with --destination, this will be ignored since the default value is used by the dialog.
  • If the user opens Save As multiple times expecting their changes to persist, they will be disappointed
    • It might be possible to make it so that they keep their changes if they exit via cancel and then re-open, but idk if this is a good idea, and would needlessly complicate the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants