Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Ores Showing Up For My Players When Not Using Any Xray #261

Open
Noobymen opened this issue Jan 10, 2023 · 11 comments
Open

Random Ores Showing Up For My Players When Not Using Any Xray #261

Noobymen opened this issue Jan 10, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@Noobymen
Copy link

Noobymen commented Jan 10, 2023

Description

When my player are just mining stuff random ores just show up for them on the ground out of no where

image

Reproduction Steps

using paper minecraft server version 1.19.3

Expected Behaviour

ores to not show up when people dont use any form of Xray

Server Details

This server is running Paper version git-Paper-370 (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT) (Git: f88384e)

Orebfuscator Version

5.3.2

ProtocolLib Version

5.0.0-SNAPSHOT-b605

Logs and Configs

No response

Extra Details

BTW picture provided is taken from a vanilla minecraft launcher no texture packs enabled also not a texture pack on the server

@Noobymen Noobymen added the bug Something isn't working label Jan 10, 2023
@Noobymen Noobymen changed the title Random Ores Showing Up For My PLayers When Not Using Any Xray Random Ores Showing Up For My Players When Not Using Any Xray Jan 10, 2023
@Ingrim4
Copy link
Member

Ingrim4 commented Jan 15, 2023

Did the player break the blocks with a vanilla pickax or some tool from a plugin/mod that can break blocks for you?

@Noobymen
Copy link
Author

Noobymen commented Jan 15, 2023

Did the player break the blocks with a vanilla pickax or some tool from a plugin/mod that can break blocks for you?

At the time off the screenshot the player was using a vanilla shovel but i got a plugin instald called slimefun but at this time this player did not use any slimefun tools just vanilla shovel

@Ingrim4
Copy link
Member

Ingrim4 commented Jan 16, 2023

Is this a reoccurring problem or something that only happened once? Are their any other plugins that might change block breaking behavior or block drops in any way?

@Noobymen
Copy link
Author

Is this a reoccurring problem or something that only happened once? Are their any other plugins that might change block breaking behavior or block drops in any way?

Yes it happends many time and about plugins maybe slimefun will do that yeah

@Ingrim4
Copy link
Member

Ingrim4 commented Jan 30, 2023

Not sure if this is the same problem as in #255. Could you try if this will fix it for you (might tank performance a little bit though): https://github.com/Imprex-Development/Orebfuscator/suites/10133768419/artifacts/494732678

@Noobymen
Copy link
Author

Noobymen commented Feb 6, 2023

Not sure if this is the same problem as in #255. Could you try if this will fix it for you (might tank performance a little bit though): https://github.com/Imprex-Development/Orebfuscator/suites/10133768419/artifacts/494732678

Yeah i tested this and now no random ores pop up anymore so what ever is in this version off the plugin it needs to be implement into the official version off the plugin

@roracle
Copy link

roracle commented Feb 8, 2023

Hello. I can confirm that using Slimefun's Gold Pan item leaves obfuscated ores visible. This is happening due to the gold pan pretty much removing the gravel block instead of breaking it (so I assume).

@Noobymen
Copy link
Author

Noobymen commented Feb 8, 2023

Hello. I can confirm that using Slimefun's Gold Pan item leaves obfuscated ores visible. This is happening due to the gold pan pretty much removing the gravel block instead of breaking it (so I assume).

Me too just tested it with the modified plugin you give me off orebfuscator random ores pop up when using gold pan from slimefun to get item's from gravel @Ingrim4

@roracle
Copy link

roracle commented Feb 11, 2023

Hello. I can confirm that using Slimefun's Gold Pan item leaves obfuscated ores visible. This is happening due to the gold pan pretty much removing the gravel block instead of breaking it (so I assume).

Me too just tested it with the modified plugin you give me off orebfuscator random ores pop up when using gold pan from slimefun to get item's from gravel @Ingrim4

Paper has built in obfuscation now. I might be trying that out next week. Our server really doesn't need it though, since SF has the Advanced Industrial Miner, there's almost no point in using xray.

@Ingrim4
Copy link
Member

Ingrim4 commented Feb 11, 2023

Yeah i tested this and now no random ores pop up anymore so what ever is in this version off the plugin it needs to be implement into the official version off the plugin

I will try to add this to the master branch once I have more time (at the earliest next month).

Hello. I can confirm that using Slimefun's Gold Pan item leaves obfuscated ores visible. This is happening due to the gold pan pretty much removing the gravel block instead of breaking it (so I assume).

We do expose an API for other plugins that change blocks and SlimeFun once had an update Orebfuscator integration but I guess they didn't add new items to said integration. Nothing we can do about it, papers built-in anti-xray might also have the same issue because I don't know if they trigger block updates if a plugin changed a block.

Paper has built in obfuscation now. I might be trying that out next week. Our server really doesn't need it though, since SF has the Advanced Industrial Miner, there's almost no point in using xray.

Their are multiple reason why Orebfuscate is still being maintained in spite of papers built-in anti-xray. Here is a short list of them: https://github.com/Imprex-Development/Orebfuscator/wiki/Frequently-Asked-Questions#why-use-orebfuscator-over-papers-built-in-anti-xray

@NgLoader NgLoader self-assigned this Apr 14, 2023
@NgLoader
Copy link
Member

Related to Slimefun/Slimefun4#3764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants