Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions system, some options (config) & commands #35

Open
Chevels opened this issue Aug 15, 2020 · 8 comments
Open

Permissions system, some options (config) & commands #35

Chevels opened this issue Aug 15, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Chevels
Copy link

Chevels commented Aug 15, 2020

Hello :)

Apparently the permissions don't work since you took over the project, and I wanted to suggest that you put them back. The Orebfuscator.deobfuscate: true permission was very useful to us because some members (as me) can no longer play when there is orebfuscator. Their FPS drops drasticaly and this permission allowed obfuscation to be disabled for players with low PCs.
Personally my FPS are 50-60 without OFC, and drop to 10-15 when I reinstall OFC on my server. Without this permission I can't even play on my own server^^

The NoObfuscationForOps: true, NoObfuscationForPermission: true and LoginNotification: true options have also disappeared from the config file.

It would be nice if you could re-add the following commands:
/ ofc status
/ ofc clearcache
/ ofc reload

Thank you for your work on this plugin !!

@Ingrim4 Ingrim4 added the enhancement New feature or request label Aug 15, 2020
@Ingrim4
Copy link
Member

Ingrim4 commented Aug 15, 2020

The permission is already in the plugin and called "orebfuscator.bypass". When you bypass the obfuscation you will get a message in chat telling you that you're bypassing the obfuscation if you enabled general.bypassNotification in your config. Regarding your loss of FPS this is probably because the server and game either run on the same machine or transparent/half blocks have a heigh weight in your config.

Commands are planned but currently not being developed on regardless thank you for your suggestions we will consider them when implementing the command system.

@Chevels
Copy link
Author

Chevels commented Aug 16, 2020

Oh thanks you ! I have not been able to find documentation for permissions.

My server is hosted by a host and we have 16GB of dedicated ram and 8 dedicated cores at 5Ghz each. Server isn't affected by OFC or a little bit. It is therefore not hosted on my PC^^
The config of OFC is config by default, so transparent/half blocks have default value. I would be very interested if you could advise me on a less resource intensive setting for customers.
My PC only runs the game client when I play. Some players lose more and more FPS over time when standing still. While doing tests with members, we have found that FPS are divided by 2 or 3 with some players when OFC is loaded.

Thank you for considering my suggestion :)

@Ingrim4
Copy link
Member

Ingrim4 commented Aug 16, 2020

The simplest way would be to remove air from all randomBlocks sections. This should improve your FPS since all the internal ChunkRenderBuffer should be less complex and simpler to build for the client. But I haven't tested this this is just my theory.

This was referenced Sep 1, 2020
Closed
@Ingrim4 Ingrim4 mentioned this issue Sep 17, 2020
@Xaldrosis
Copy link

I have turned off air blocks, it improved the fps slightly. You start off at normal fps and then it tanks down. One user even went down from 98 fps to 17 fps.

@Chevels
Copy link
Author

Chevels commented Sep 17, 2020

I'm sorry, I forgot to follow up on your advice @Ingrim4 .
Since I deactivated the air blocks, all members who complained of high FPS drop no longer have any concerns, same for me. Thank you !

@Xaldrosis
Copy link

Xaldrosis commented Sep 17, 2020

Small update, looks like the issue mostly has to do with certain resource packs. FPS seems to be fixed after removing airblocks and switching the resource packs to something else that has no issue with this mod.

@TimurYP
Copy link

TimurYP commented Feb 18, 2021

Hi, I'm having difficulty, how to disable obfuscation for OP players on version 1.16.4?

@Ingrim4
Copy link
Member

Ingrim4 commented Feb 18, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants