Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs and errors #11

Open
SharkOverBite opened this issue Jul 14, 2024 · 0 comments
Open

Bugs and errors #11

SharkOverBite opened this issue Jul 14, 2024 · 0 comments

Comments

@SharkOverBite
Copy link

  1. There is no requirements.txt, nor do the docs list the python dependencies. Neither the docs nor the installation script indicate that pypubsub (and once you get an importError exception, that pip install pubsub installs the wrong package. How long before python-pubsub and python-pubsub2 arrive on the scene is anybody's guess) is a hard dependency.
  2. In all place where it appears, the "Back button" uses an icon universally acknowledged as the symbol for "Undo". The universal icon for back is "Left Arrow". As you can plainly see if you look at a little higher, just a bit more, no, right by the address bar, sorry I meant to the left. See the back button right there? that icon is the universal icon for back button.
  3. the tooltip for the "TPM Clear Disable" button is wrong
  4. the tooltip for the "TPM Clear Enable button is wrong
  5. All the panes uses a rather large font, and the text gets cutoff because of insufficient height for widgets, unless I toggle the app's window to fullscreen mode and back (I use the sway window manager)
    TPM
  6. In informaional text "Enhanced Authorization Information", substitute "In this case, apolicy is created." for "In this case, the policy is created. ". substitute "creation of a primary key (if not already done)" for "creation of a primary (if not already done)". Substitute "which a requires a PCR back to have a specific value" for "which a requires a PCR back to the specific value". substitute "A policy can have just one condition" for "A policy can only have 1 condition". substitute "a complex chain of conditions" for "or a complex chain of conditions".
  7. The back button is in the same place on every pane, except the "cryptographic functions" pane. Consistency really matters in User Interfaces.
  8. Whenever I try to create a primary key (which tries to set a password auth) through the explorer I get an error. The tool expect me to have used the GUI to set an owner auth. If I haven't (and just want to use an empty auth value), creating a primary key fails.
Creating RSA Primary Key (may take a while)...
WARNING:esys:src/tss2-esys/api/Esys_CreatePrimary.c:401:Esys_CreatePrimary_Finish() Received TPM Error 
ERROR:esys:src/tss2-esys/api/Esys_CreatePrimary.c:135:Esys_CreatePrimary() Esys Finish ErrorCode (0x000009a2) 
ERROR: Esys_CreatePrimary(0x9A2) - tpm:session(1):authorization failure without DA implications
ERROR: Unable to run tpm2_createprimary
ERROR: Incorrect handle value, got: "RSAprimary.ctx", expected expected [o|p|e|n|l] or a handle number
ERROR: Unable to read as BIO file
ERROR: Unable to fetch public/private portions of TSS PRIVKEY
ERROR: Cannot make sense of object context "RSAprimary.ctx"
ERROR: Unable to run tpm2_evictcontrol

tpm2_createprimary -C o -P owner123 -g sha256 -G rsa -c RSAprimary.ctx
tpm2_evictcontrol -C o -c RSAprimary.ctx -P owner123 0x81000004
++++++++++++++++++++++++++++++++++++++++++++
  1. When I try to create a primary, and am asked to provide the owner auth, If I simply set the password textbox to an empty string, the application ignores me and uses the default Owner123 password instead.
  2. after running create_binary_package.sh, it's a shame that running start_gui.sh from another directory fails to launch the program because it can't find main.pyc. The shell script should simply cd to its containing directory and launch.
  3. there is no item no. 11
  4. unless that one counts
  5. Thank you
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant