Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMOLED Dark mode #2

Closed
skye-repos opened this issue May 31, 2023 · 12 comments
Closed

AMOLED Dark mode #2

skye-repos opened this issue May 31, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@skye-repos
Copy link

Hi!

it would be really cool there were an extra dark mode ala AMOLED black. Not sure where to start with that though.

@InioX InioX changed the title Extra Dark mode AMOLED Dark mode Jun 2, 2023
@InioX
Copy link
Owner

InioX commented Jun 2, 2023

Hi, thanks for the suggestion! I could probably try adding a new function that would modify the dark_from_core_palette one to have an amoled background, but that's just my first thought.

@InioX InioX added the enhancement New feature or request label Jun 2, 2023
InioX pushed a commit that referenced this issue Jun 2, 2023
feat: implement quantize module
@InioX
Copy link
Owner

InioX commented Jun 2, 2023

I kinda got this to work, I just need to add a flag for it. What colors apart from background and surface should i change?
image

@skye-repos
Copy link
Author

It would be cool if you could split the primary color into two component colors and make them secondary and tertiary.

If that's not possible, I think background and surface is pretty cool!

@skye-repos
Copy link
Author

Also, thank you!

@InioX
Copy link
Owner

InioX commented Jun 2, 2023

It would be cool if you could split the primary color into two component colors and make them secondary and tertiary.

I'm sorry, but I don't understand what you mean by that. Could you please explain it a bit more?

@InioX
Copy link
Owner

InioX commented Jun 2, 2023

Also, after trying the "pure black" mode on my Android, I should probably dim the other surface colors a bit to make them look similar.

@skye-repos
Copy link
Author

skye-repos commented Jun 2, 2023

So, suppose that the primary family is a purple-ish, lavendar-ish color.

Secondary could be a blue and tertiary can be a red/pink.

There may be a sophisticated algorithm for this, but I was just thinking along the lines of

#aa88ff ---> #aa4400 + #0044ff

basically, we see which color channel is the dimmest and split across that axis?

@InioX
Copy link
Owner

InioX commented Jun 2, 2023

I hope I understand now, did you mean something like this?

If that's what you mean, you can use these colors already. The list of all the colors is right here.

@skye-repos
Copy link
Author

If my understanding is correct, these are shades/variant on a monotone pallette.

I was looking for something more like a tritone pallette?

InioX added a commit that referenced this issue Jun 3, 2023
@InioX
Copy link
Owner

InioX commented Jun 3, 2023

So, I would shift the hue for the secondary/tertiary colors like this?

@skye-repos
Copy link
Author

Yeah! The triadic palette takes colors evenly across the color wheel, while i was imagining something more like the adjacent scheme that you can play around with here.

https://paletton.com/#uid=54H0L0kAarQnc-Zu6zgEqmCKJhf

There are other versions like complimentary and tetradic too. Since the monet palette is built around three colors, the triadic or adjacent palettes would be cool additions

@InioX
Copy link
Owner

InioX commented Jun 3, 2023

The link you provided me really helped me understand, I could try adding that. Since the amoled mode was added though, I should close this issue. Please make another one for the different secondary/tertiary colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants