Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Color Schemes #5

Closed
skye-repos opened this issue Jun 4, 2023 · 4 comments
Closed

Additional Color Schemes #5

skye-repos opened this issue Jun 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@skye-repos
Copy link

Hi!

As requested, I'm making a new issue/feature request for adding other non monotone color schemes in different schema such as

  1. Triadic
  2. Tetradic
  3. Adjacent
  4. Complimentary

my preference would be Triadic or Adjacent since they already fit into the three-color format used by the monet engine.

Best,
KSH

@InioX InioX added the enhancement New feature or request label Jun 4, 2023
@InioX
Copy link
Owner

InioX commented Jun 4, 2023

Hey! It's somewhat done, I just don't know the exact values to shift the hue. Maybe you could help adjust those, the commit should be on the testing branch, and the file with hues is here.

recording.mp4

@skye-repos
Copy link
Author

Hi!

Sorry, for the delay, i'll get on it once i have some free time and get back to you. Not sure how to do a PR and stuff like that.

@skye-repos
Copy link
Author

Hi!

I think this algorithm works! I just have a couple of sugesstions regarding the adjacent scheme

  1. can you add an 'angle' param? right now, its from_hue_and_chrome(hue +- 30, chroma / 3). If we can tune it to (hue +- angle, chroma / 3) ?

  2. also, why does a2 have chroma/ 3 but a3 have chroma / 2 ? Did i misunderstand something?

I don't have access to a computer with git atm, so sorry I couldn't make the changes directly.

@InioX
Copy link
Owner

InioX commented Jun 7, 2023

Hello, @Harith163!

  1. can you add an 'angle' param? right now, its from_hue_and_chrome(hue +- 30, chroma / 3). If we can tune it to (hue +- angle, chroma / 3) ?

Sure!

  1. also, why does a2 have chroma/ 3 but a3 have chroma / 2 ? Did i misunderstand something?

I have no idea to be honest. I took a look at both the c++ and typescript core palette files, but I couldn't find a reason why it is that way. Their site also doesn't have a lot of information about the core palette generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants