Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline alignment regression #141

Closed
Tracked by #196
CosmicHorrorDev opened this issue Jun 4, 2023 · 1 comment · Fixed by #226
Closed
Tracked by #196

Underline alignment regression #141

CosmicHorrorDev opened this issue Jun 4, 2023 · 1 comment · Fixed by #226
Labels
C-bug Category: Something isn't working

Comments

@CosmicHorrorDev
Copy link
Collaborator

cc @trimental

Just noticed that the PR to add alignment for tables regressed alignment for text vs its underline

Repro

<h1 align="center">Some text</p>

Rendered

image

You can see that the text is center aligned while the underline is left aligned

This seems to be due to removing the alignment from the Key which was used to set the alignment of the buffer_line. Admittedly I'm not really familiar enough with the renderer to know how to fix things without likely regressing other parts

@trimental
Copy link
Collaborator

Yep haha. Currently trying to fix this issue. Getting close to honing in on it but it's a tricky one. Going to need more time to sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants