Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra keybindings should have precedence over base #188

Closed
CosmicHorrorDev opened this issue Dec 10, 2023 · 0 comments · Fixed by #224
Closed

extra keybindings should have precedence over base #188

CosmicHorrorDev opened this issue Dec 10, 2023 · 0 comments · Fixed by #224
Labels
A-keybinding Area: Related to keycombos/keybindings C-enhancement Category: New feature or request E-easy Experience needed: Easy (good first issue)

Comments

@CosmicHorrorDev
Copy link
Collaborator

The purpose of extra was to give the user control over changing just a couple of keybindings here and there while still making use of the defaults (base). The current design partially fulfills this purpose by giving the option to add additional keybindings, but it's limited in that you can't override individual keybindings. It would be nice if extra keybindings had a higher precedence than base in that keybindings that appear in both will use the extra version instead of choking on a conflict

Notably this won't address conflicts where a keybinding in one prefixes some keybinding in the other, but I don't know of a good resolution there. I think as it stands now any additional keybindings will have to be added with a semver breaking bump

@CosmicHorrorDev CosmicHorrorDev added C-enhancement Category: New feature or request A-keybinding Area: Related to keycombos/keybindings labels Dec 10, 2023
@CosmicHorrorDev CosmicHorrorDev added the E-easy Experience needed: Easy (good first issue) label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keybinding Area: Related to keycombos/keybindings C-enhancement Category: New feature or request E-easy Experience needed: Easy (good first issue)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant