Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Hacking to get GDCM to work with libjpeg-turbo #5061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blowekamp
Copy link
Member

Must work to still be done, but looks likes a plausible path forward.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Sorry, something went wrong.

@blowekamp
Copy link
Member Author

@seanm

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module type:Data Changes to testing data labels Dec 13, 2024
@seanm
Copy link
Contributor

seanm commented Dec 13, 2024

Neat. So you're hacking here in ITK then I guess you'd make in PR in GDCM itself eventually?

@blowekamp
Copy link
Member Author

Neat. So you're hacking here in ITK then I guess you'd make in PR in GDCM itself eventually?

I don't think I will have time to follow through with this to GDCM. Consider this just a proof of concept that switching to libjpeg-turbo should work. I'm not sure if it would be best to have GDCM support this external option for this, or if the internal jpeg library should be updated/changed. @malaterre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Data Changes to testing data type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants