Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate declaration warnings in dashboard #266

Closed
jhlegarreta opened this issue Mar 21, 2021 · 7 comments · Fixed by #327
Closed

Duplicate declaration warnings in dashboard #266

jhlegarreta opened this issue Mar 21, 2021 · 7 comments · Fixed by #327

Comments

@jhlegarreta
Copy link
Member

The Linux Examples Documentation build of the Insight dashboard:
https://open.cdash.org/viewBuildError.php?type=1&buildid=7112107

is signalling duplicate declaration warnings for the classes that are marked as being demonstrated in each example's Documentation.rst file with the .. breathelink:: tag:
e.g.

[CTest: warning matched]
/home/kitware/Dashboards/Tests/ITKExamples-doc-build/ITKEx-buildCore/Common/
BuildAHelloWorldProgram/Documentation.rst:102:
WARNING: Duplicate declaration,
template<typename TPixel, unsigned int VImageDimension = 2> itk::Image :
public itk::ImageBase< VImageDimension >

Not sure why this is being reported. Also, the build seems not to trigger nightly (or it might take a long time to build), and hence the reporting frequency is not consistent.

@jhlegarreta jhlegarreta changed the title Duplicate declaration warnings on dashboard Duplicate declaration warnings in dashboard Mar 21, 2021
@dzenanz
Copy link
Member

dzenanz commented Dec 27, 2021

I think this was resolved meanwhile. Can you confirm Jon?

@jhlegarreta
Copy link
Member Author

I think this was resolved meanwhile. Can you confirm Jon?

I am unable to find recent builds in the dashboard, even going a few days back. So I cannot confirm. But if you feel confident that it has been resolved, please close the issue 👍.

Thanks for the effort @dzenanz.

@dzenanz
Copy link
Member

dzenanz commented Dec 27, 2021

What kind of build are you looking for? Does today's CI build or its dashboard work?

@jhlegarreta
Copy link
Member Author

I was looking at the dashboard regular builds, as the issue report build seemed a regular build that was reporting about the examples documentation builds.

@tbirdso
Copy link
Contributor

tbirdso commented Mar 11, 2022

This issue is still observed. Updating to Sphinx 4.4.0 changed the error message slightly:

ITKEx-build/src/Bridge/VtkGlue/ConvertAnitkImageTovtkImageData/Documentation.rst:131: WARNING: Duplicate C++ declaration, also defined at src/Bridge/VtkGlue/ConvertAnRGBitkImageTovtkImageData/Documentation:129.

Please see #324 for additional investigation notes to date. 50 warnings about duplicate declarations in breathelinks are blocking CI from publishing updating docs.

@thewtex
Copy link
Member

thewtex commented Mar 12, 2022

@tbirdso thanks for the detailed investigation!

It sounds like we should exclude the warnings here:

set(CTEST_CUSTOM_WARNING_EXCEPTION
${CTEST_CUSTOM_WARNING_EXCEPTION}
"has no symbols"
"ipo: warning #11053"
"ipo: warning #11053"
"vxl.core.vnl.algo"
"vxl.core.vnl"
"vxl.v3p.netlib"
"itkjpeg"
"usr.include.stdint.h"
"Warning itk::Statistics::Histogram"
"itkIOCommonTest.cxx:.*warning:.* is deprecated"
"/usr/bin/ld: warning: libnetcdf.so.3, needed by.*may conflict with libnetcdf.so.4"
"itkQuadEdgeMeshEdgeMergeDecimationFilter.hxx:.*warning: unused parameter.*iEdge.*"
"vnl_diag_matrix.h"
"WARNING non-zero return value in ctest"
"Warning.*Anachronism.*"
"attempted multiple inclusion of file"
"warning LNK4221"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Dd][Ii][Cc][Oo][Mm][Pp]arser[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Ee]xpat[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Kk][Ww][Ss]ys[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Mm]eta[Ii][Oo][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn]etlib[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn][Ii][Ff][Tt][Ii][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Oo]pen[Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Pp][Nn][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Tt][Ii][Ff][Ff][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][Ii]nstantiation[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Zz][Ll][Ii][Bb][/\\\\].*[Ww]arning.*"
".*Microsoft.*include.*win.*.h.*[Ww]arning.*"
".*include.opencv2.*warning.*"
".*core.vidl.*warning.*"
".*core.vnl.vnl_matrix_fixed.h.*warning.*"
# DCMTK
"Note: checking out.*"
"-- Warning: SNDFILE support will be disabled because libsndfile was not found.*"
# FFTW ExternalProject
".*fftw[fd]/src/fftw[fd]./*"
"libtool: install: warning: relinking .libfftw3f?_threads.la."
# OpenCV
"opencv/modules"
# Ignore clang's summary warning, assuming prior text has matched some
# other warning expression:
"[0-9,]+ warnings? generated."
)

@tbirdso
Copy link
Contributor

tbirdso commented Mar 14, 2022

After adding the warning to be excluded in #327 it looks like the build is still failing with CDash warnings 😕

@thewtex @dzenanz Do you have ideas on what I might be doing wrong? It looks like the other warning exclusions in the file were copied from ITK, I'm not sure whether they are being used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants