Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable warning #1187

Closed
zhubofei opened this issue May 26, 2018 · 2 comments
Closed

Unused variable warning #1187

zhubofei opened this issue May 26, 2018 · 2 comments
Assignees
@zhubofei
Labels
bug
Milestone
4.0.0

Comments

@zhubofei
Copy link

zhubofei commented May 26, 2018 •
edited
Loading

IGListKit/Source/IGListAdapter.m

Line 1083 in 290d592

UICollectionView *collectionView = self.collectionView;

Travis failed after a swiftlint warning: unused variable collectionView [-Wunused-variable]
@rnystrom
Copy link
Contributor

Ahh from compiling out the assert. Any interest picking this up and fixing? Should be just changing the assert to use self.collectionView instead.

Sent with GitHawk

@rnystrom rnystrom added the bug label May 27, 2018
@zhubofei
Copy link
Author

Sure 😊

@zhubofei zhubofei self-assigned this May 27, 2018
@zhubofei zhubofei mentioned this issue May 27, 2018
Closed
4 tasks
@zhubofei zhubofei added this to the 4.0.0 milestone May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhubofei zhubofei

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Removed unused variable bofeizhu/IGListKit
2 participants
@rnystrom @zhubofei