Remove nibName argument from IGListReusableViewIdentifier

[zhubofei]

IGListKit/Source/Internal/IGListAdapterInternal.h

Lines 20 to 23 in bee2178

	/// Generate a string representation of a reusable view class when registering with a UICollectionView.
	NS_INLINE NSString *IGListReusableViewIdentifier(Class viewClass, NSString * _Nullable nibName, NSString * _Nullable kind, NSString * _Nullable givenReuseIdentifier) {
	return [NSString stringWithFormat:@"%@%@%@%@", kind ?: @"", nibName ?: @"", givenReuseIdentifier ?: @"", NSStringFromClass(viewClass)];
	}

nibName was never used and should not be used to generate identifiers.

[rnystrom]

Wait is that correct? Shouldn’t it have been used?

_{Sent with GitHawk}

[zhubofei]

@rnystrom

IGListKit/Source/IGListAdapter.m

Lines 1007 to 1024 in c5f6406

	- (UICollectionViewCell *)dequeueReusableCellWithNibName:(NSString *)nibName
	bundle:(NSBundle *)bundle
	forSectionController:(IGListSectionController *)sectionController
	atIndex:(NSInteger)index {
	IGAssertMainThread();
	IGParameterAssert([nibName length] > 0);
	IGParameterAssert(sectionController != nil);
	IGParameterAssert(index >= 0);
	UICollectionView *collectionView = self.collectionView;
	IGAssert(collectionView != nil, @"Dequeueing cell with nib name %@ and bundle %@ from section controller %@ without a collection view at index %li.", nibName, bundle, sectionController, (long)index);
	NSIndexPath *indexPath = [self indexPathForSectionController:sectionController index:index usePreviousIfInUpdateBlock:NO];
	if (![self.registeredNibNames containsObject:nibName]) {
	[self.registeredNibNames addObject:nibName];
	UINib *nib = [UINib nibWithNibName:nibName bundle:bundle];
	[collectionView registerNib:nib forCellWithReuseIdentifier:nibName];
	}
	return [collectionView dequeueReusableCellWithReuseIdentifier:nibName forIndexPath:indexPath];
	}

Right now, nibNames are used as identifiers directly.