We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right now to get the object from the selectionDelegate, you have to:
selectionDelegate
func didSelect(_ sectionController: IGListSingleSectionController) { let object = adapter.object(for: sectionController) // do something }
When IGListSingleSectionController already has the object, this lookup is wasteful.
IGListSingleSectionController
I propose we change the delegate method to:
- (void)didSelectSingleSectionController:(IGListSingleSectionController *)sectionController withObject:(id)object;
didSelectSectionController
The text was updated successfully, but these errors were encountered:
For the Swift interop it would be nice for something like didSelect(_ sectionController: .. with object: ..)
didSelect(_ sectionController: .. with object: ..)
If no one else takes it, I may give this a try?
reminder
Sorry, something went wrong.
279f348
Sherlouk
Successfully merging a pull request may close this issue.
Right now to get the object from the
selectionDelegate
, you have to:When
IGListSingleSectionController
already has the object, this lookup is wasteful.I propose we change the delegate method to:
didSelectSectionController
?The text was updated successfully, but these errors were encountered: