Add analyze action to .travis.yml xcodebuild calls

[benasher44]

New issue checklist

• I have reviewed the README and documentation
• I have searched existing issues and this is not a duplicate

Steps

• Fix remaining analyzer warnings.
• Add the analyze action to xcodebuild calls in .travis.yml, and ensure that builds that fail the analyzer fail the build.

[benasher44]

Fixed one analyzer issue in #51

[rnystrom]

Nice, this sounds really helpful. I imagine once the build is working we need to squish all the analyzer warnings before adding it to the .travis.yml file, so builds are green? Or add it first and try to fix the build?

[benasher44]

Yep! On master when I checked yesterday, there were 2. There's only the one left after #51. The other one seemed non-trivial to fix.

[benasher44]

The final analyzer warning was fixed by #69, which is a pretty awesome patch btw @valeriyvan! This ticket is unblocked now.