Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the need for model objects to be immutable #587

Closed
2 tasks done
robertjpayne opened this issue Mar 27, 2017 · 2 comments
Closed
2 tasks done

Document the need for model objects to be immutable #587

robertjpayne opened this issue Mar 27, 2017 · 2 comments
Labels

Comments

@robertjpayne
Copy link

robertjpayne commented Mar 27, 2017

New issue checklist

General information

This caught me out a bit, but IGListKit currently requires that an object's pointer personality changes for any type of reload action to occur.

Even if diffIdentifier changes and the isEqual value returns false if the object's pointer is the same the diff algorithm ignores it.

I understand why this is difficult to achieve but I feel like it's sort of a hidden implementation detail and there is little documentation stating that object pointer's must change for reloads to occur.

@robertjpayne
Copy link
Author

Gah I totally missed the Diff and Equality document. Sorry

@jessesquires
Copy link
Contributor

No worries! Thanks @robertjpayne ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants