Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove with self.assertRaises(Exception): #457

Open
jimmylai opened this issue Feb 9, 2021 · 1 comment
Open

Remove with self.assertRaises(Exception): #457

jimmylai opened this issue Feb 9, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jimmylai
Copy link
Contributor

jimmylai commented Feb 9, 2021

with self.assertRaises(Exception): is used in a couple places for testing an exception is raised.
It can catch any Exception which can result in catching unexpected error.
Change to use a more specific exception or use self.assertRaisesRegex instead.
@zsol zsol added the good first issue Good for newcomers label May 19, 2021
@srisatya12
Copy link

@jimmylai will work on this issue.

@zaicruvoir1rominet zaicruvoir1rominet mentioned this issue Jul 4, 2024
Open
@lizard-boy lizard-boy mentioned this issue Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zsol @jimmylai @srisatya12