New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportFrom can produce invalid code without parenthesis #532

Open

zsol opened this issue Oct 16, 2021 · 0 comments · May be fixed by #869

Labels

bug parsing

Member

zsol commented Oct 16, 2021

In fact this is captured as a test case in https://github.com/instagram/libcst/blob/f36eacb1327830fad51e08084b46601cad681ae0/libcst/_nodes/tests/test_import.py#L394-L401

cst.ImportFrom(
    module=cst.Name("foo"),
    names=(
        cst.ImportAlias(cst.Name("bar"), comma=cst.Comma()),
        cst.ImportAlias(cst.Name("baz"), comma=cst.Comma()),
    ),
)

This node generates from foo import bar,baz, which isn't syntactically correct.

The text was updated successfully, but these errors were encountered:

zsol added the bug label

zsol added the parsing label

davidshepherd7 linked a pull request

that will close this issue

Fix generating invalid trailing commas in import statements #869

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment