Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the c and cpp flags for building on osx #17

Merged
merged 2 commits into from
Mar 2, 2016

Conversation

royshil
Copy link
Contributor

@royshil royshil commented Jan 29, 2016

This fixes a problem of osx not finding the GLFW and OpenGL headers

@royshil
Copy link
Contributor Author

royshil commented Jan 30, 2016

With OS detection now it should build smoothly on linux and osx without any modification to Makefile

@ddiakopoulos
Copy link
Contributor

Thanks! We plan to merge this but we need to have Intel's legal team review a standard contributor's agreement for this project. I'll comment on this pull request directly when it is ready.

@royshil
Copy link
Contributor Author

royshil commented Jan 30, 2016

🆒

@ffurrer
Copy link
Contributor

ffurrer commented Feb 13, 2016

thanks, this works (under OSX) perfectly for me too.

@ddiakopoulos
Copy link
Contributor

@royshil we have added a CLA on the dev branch. Take a look at CONTRIBUTING.md for the full details. Once you have completed the instructions, we will accept this contribution when we merge dev back into master.

@royshil
Copy link
Contributor Author

royshil commented Feb 26, 2016

@ddiakopoulos
I agree to the terms of the librealsense CLA.

Is that sufficient?

@ddiakopoulos
Copy link
Contributor

Thanks! We'll accept/merge the pull next time we merge dev + master (in the next week, maybe?)

@royshil
Copy link
Contributor Author

royshil commented Feb 26, 2016

Perfect! glad to be of help...

On Thu, Feb 25, 2016 at 8:43 PM Dimitri Diakopoulos <
[email protected]> wrote:

Thanks! We'll accept/merge the pull next time we merge dev + master (in
the next week, maybe?)


Reply to this email directly or view it on GitHub
#17 (comment)
.

ddiakopoulos added a commit that referenced this pull request Mar 2, 2016
Fixing the c and cpp flags for building on osx
@ddiakopoulos ddiakopoulos merged commit 8c195d2 into IntelRealSense:master Mar 2, 2016
roberto-martinmartin pushed a commit to tu-rbo/librealsense that referenced this pull request May 11, 2016
This fixes Pull Request IntelRealSense#2
This fixes Issue IntelRealSense#17
dorodnic pushed a commit that referenced this pull request Aug 15, 2018
Fixing crash on init failure
nhershko pushed a commit to nhershko/librealsense that referenced this pull request Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants