Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - TxVotingProcedures accepts ScriptWitness but not broader Witness type #722

Open
sourabhxyz opened this issue Jan 12, 2025 · 1 comment
Open

[FR] - TxVotingProcedures accepts ScriptWitness but not broader Witness type #722

sourabhxyz opened this issue Jan 12, 2025 · 1 comment

Comments

@sourabhxyz
Copy link

External

Area
Transaction building.

Describe the feature you'd like
Constructors such as TxWithdrawals, TxCertificates accepts Witness under BuildTxWith but TxVotingProcedures utilizes ScriptWitness which does not include key witnesses. Is this deliberate? Is it that key witnesses don't make sense in this context? If key witnesses make sense for voting procedures, then not including them may mess up with functions like estimateTransactionKeyWitnessCount.
Thanks!
@smelc
Copy link
Contributor

smelc commented Jan 13, 2025

cc @CarlosLopezDeLara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smelc @sourabhxyz