Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print fee integer value rather than Lovelace value in calculate-min-fee command #1401

Closed
intricate opened this issue Jul 7, 2020 · 3 comments · Fixed by #1408
Closed

Print fee integer value rather than Lovelace value in calculate-min-fee command #1401

intricate opened this issue Jul 7, 2020 · 3 comments · Fixed by #1408
Assignees
@Jimbo4350
Labels
cli revision is used to group all the Node CLI tickets enhancement New feature or request minorfix Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai

Comments

@intricate
Copy link
Contributor

As of right now, the output for the shelley transaction calculate-min-fee command looks something like this:

Lovelace 2594002

when we'd rather just print the integer value:

2594002
@intricate intricate added the cli revision is used to group all the Node CLI tickets label Jul 7, 2020
@erikd
Copy link
Contributor

erikd commented Jul 7, 2020

Maybe it should say 2594002 Lovelace instead.

@vix-io vix-io added the enhancement New feature or request label Jul 7, 2020
@kevinhammond
Copy link
Contributor

Is there a problem with running the output through e.g. awk?

@kevinhammond kevinhammond added minorfix Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai labels Jul 7, 2020
@intricate intricate mentioned this issue Jul 7, 2020
Merged
@erikd
Copy link
Contributor

erikd commented Jul 7, 2020

Yes, the problem is that most people do not know awk.

@iohk-bors iohk-bors bot closed this as completed in 2451cea Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jimbo4350 Jimbo4350

Labels
cli revision is used to group all the Node CLI tickets enhancement New feature or request minorfix Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve output of Shelley calculate-min-fee command IntersectMBO/cardano-node
5 participants
@erikd @Jimbo4350 @kevinhammond @intricate @vix-io