Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Rename TestEnableDevelopmentHardForkEras to TestEnableDevelopmentProtVer #4470

Closed
2 of 13 tasks
LudvikGalois opened this issue Sep 23, 2022 · 3 comments · Fixed by #4341
Closed
2 of 13 tasks

Feature: Rename TestEnableDevelopmentHardForkEras to TestEnableDevelopmentProtVer #4470

LudvikGalois opened this issue Sep 23, 2022 · 3 comments · Fixed by #4341
Assignees
@LudvikGalois
Labels
Stale type: internal feature Non user-facing functionality user type: internal Created by an IOG employee

Comments

@LudvikGalois
Copy link
Contributor

LudvikGalois commented Sep 23, 2022 •
edited
Loading

What

Rename TestEnableDevelopmentHardForkEras to TestEnableDevelopmentProtVer

Why

The TestEnableDevelopmentHardForkEras flag is set when a node wants to enable support for the "new" protocol version
before it is actually released. It was decided that this is a bad name for the feature, so it's been renamed to something
hopefully more indicative about what it does.

Personas - Who will this affect?

  • SPO
  • Dapp Devs
  • Exchanges

Acceptance Criteria

Definition of done

  • Code review
  • Builds successfully on CI
  • Includes documentation and/or examples for the functionality
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number included in PR description
  • The new functionality is covered by dev/unit/property tests
  • Acceptance Criteria met
  • Test Engineering Sign-off + E2E automated tests

Sign-off

  • Dev
  • Test Engineering

Related PR

  1. Rename TestEnableDevelopmentHardForkEras and TestEnableDevelopmentNetworkProtocols #4341
@LudvikGalois LudvikGalois self-assigned this Sep 23, 2022
@LudvikGalois LudvikGalois mentioned this issue Sep 23, 2022
Merged
@dorin100
Copy link

@CarlosLopezDeLara can you please add the AC?

@dorin100 dorin100 mentioned this issue Sep 23, 2022
Closed
@CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara can you please add the AC?

Not a user-facing feature.

@dorin100 dorin100 added type: internal feature Non user-facing functionality user type: internal Created by an IOG employee labels Oct 24, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LudvikGalois LudvikGalois

Labels
Stale type: internal feature Non user-facing functionality user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
3 participants
@LudvikGalois @dorin100 @CarlosLopezDeLara