Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-node should improve logging clarity #4630

Open
sunapi386 opened this issue Nov 10, 2022 · 3 comments
Open

cardano-node should improve logging clarity #4630

sunapi386 opened this issue Nov 10, 2022 · 3 comments
Assignees

Comments

@sunapi386
Copy link

Internal/External
External otherwise.

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
Cardano-node logs include too much unnecessary haskell data-structure specific information. This is bad because it is increases log size without providing any additional value.

E.g.

Nov 10 12:13:07 relay1 cardano-node[66273]: [relay1:cardano.node.Mempool:Info:207475] [2022-11-10 20:13:07.06 UTC] fromList [("kind",String "TraceMempoolAddedTx"),("mempoolSize",Object (fromList [("bytes",Number 36322.0),("numTxs",Number 21.0)])),("tx",Object (fromList [("txid",String "879588a7")]))]
Nov 10 12:13:08 relay1 cardano-node[66273]: [relay1:cardano.node.LeadershipCheck:Info:154] [2022-11-10 20:13:08.00 UTC] {"chainDensity":4.8895936e-2,"credentials":"Cardano","delegMapSize":1226822,"kind":"TraceStartLeadershipCheck","slot":76544897,"utxoSize":8906282}
Nov 10 12:13:08 relay1 cardano-node[66273]: [relay1:cardano.node.Forge:Info:154] [2022-11-10 20:13:08.02 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNodeNotLeader"),("slot",Number 7.6544897e7)]))]
Nov 10 12:13:09 relay1 cardano-node[66273]: [relay1:cardano.node.LeadershipCheck:Info:154] [2022-11-10 20:13:09.00 UTC] {"chainDensity":4.8895936e-2,"credentials":"Cardano","delegMapSize":1226822,"kind":"TraceStartLeadershipCheck","slot":76544898,"utxoSize":8906282}
Nov 10 12:13:09 relay1 cardano-node[66273]: [relay1:cardano.node.Forge:Info:154] [2022-11-10 20:13:09.02 UTC] fromList [("credentials",String "Cardano"),("val",Object (fromList [("kind",String "TraceNodeNotLeader"),("slot",Number 7.6544898e7)]))]
Nov 10 12:13:09 relay1 cardano-node[66273]: [relay1:cardano.node.Mempool:Info:207475] [2022-11-10 20:13:09.92 UTC] fromList [("kind",String "TraceMempoolAddedTx"),("mempoolSize",Object (fromList [("bytes",Number 41599.0),("numTxs",Number 22.0)])),("tx",Object (fromList [("txid",String "bc6ac097")]))]

Steps to reproduce
Steps to reproduce the behavior:

  1. Run cardano-node.
  2. View the logs.

Expected behavior
I hope the logs reduce the amount printed and improve readability overall.

System info (please complete the following information):

  • OS Name: Ubuntu
  • OS Version 20.04
  • Node version cardano-node 1.35.3 - linux-x86_64 - ghc-8.10 git rev 950c4e2
  • CLI version cardano-cli 1.35.3 - linux-x86_64 - ghc-8.10 git rev 950c4e2
@sunapi386 sunapi386 added the type: bug Something is not working label Nov 10, 2022
@Jimbo4350 Jimbo4350 removed the type: bug Something is not working label Nov 11, 2022
@Jimbo4350 Jimbo4350 changed the title [BUG] - cardano-node should improve logging clarity cardano-node should improve logging clarity Nov 11, 2022
@coot
Copy link
Contributor

coot commented Nov 21, 2022

@sunapi386 I aggree, especially we should not use show for data which contains Value (which is an intermediate representation of json in Haskell).

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@erikd
Copy link
Contributor

erikd commented May 11, 2023

I think this needs to be kept alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants