Empty string given as the foreign key ID for an aggregate_belongs_to attribute ends up storing the ID as 0

[omeedrj]

Description

id_or_value.to_i within Aggregate::ForeignKeyReference#initialize can cause an empty string given as an id to be stored as 0. This 0 will then be stored as the aggregate_belongs_to attribute's ID in serialized storage data. This means that trying to fetch the associated DB record will (most likely always) raise an exception because the record won't be found, which ends up becoming confusing to debug because it's not necessarily clear to the consumer of the gem why 0 is being stored as the ID.

aggregate/lib/aggregate/foreign_key_reference.rb

Line 13 in edd6252

@id = id_or_value.to_i

Example

aggregate_belongs_to :user, "User"

my_object.user_id = ""
my_object.save!

my_object.user_id == 0

Suggested Fix

• When id_or_value is not an ActiveRecord::Base object, we should raise an ArgumentError if id_or_value is nil or an empty string

[dep]

Discovered during the creation of this invoca/web PR. Linking for posterity.