Islandora Settings offers invalid time expression

[kayakr]

On Islandora Settings in Drupal (/admin/config/islandora/core) the JWT Expiry field description suggests times like 60, "2 days", "10h", "7d" but if you try 7d the form errors with "7d" is not a valid time or interval expression." Do the offered times all need "+" added, e.g. +7d works.

[seth-shaw-unlv]

Ah, you are right. It validates using strtotime. All the examples should be valid relative forms which, for the existing ones, require the "+" sign at the beginning (because using the minus makes no sense in this context). The line to update is here.

[whikloj]

Would this benefit from some help in the validation function? Like assuming/requiring a + because a JWT with a - is kinda useless.

[seth-shaw-unlv]

@whikloj, sure. The validation code currently insists it is a valid time, although we could improve the validation error message.

[rosiel]

Still an issue, in a way. '2 days' does not validate because 'day' is not listed as one of the valid time intervals. Yet it's in the suggested text.

[seth-shaw-unlv]

Thanks, @rosiel for wrapping this up for us!