Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update karaf to 4.0.3 #57

Closed
ruebot opened this issue Oct 7, 2015 · 9 comments
Closed

update karaf to 4.0.3 #57

ruebot opened this issue Oct 7, 2015 · 9 comments
Assignees

Comments

@ruebot
Copy link
Member

ruebot commented Oct 7, 2015

No description provided.

@ruebot ruebot self-assigned this Oct 7, 2015
@ruebot ruebot added this to the Community Sprint - 01 milestone Oct 7, 2015
@acoburn
Copy link
Contributor

acoburn commented Oct 23, 2015

Just as a note, the latest Karaf release is now 4.0.2

@ruebot
Copy link
Member Author

ruebot commented Oct 23, 2015

I'll update the ticket 😄

@ruebot ruebot changed the title update karaf to 4.0.1 update karaf to 4.0.2 Oct 23, 2015
@daniel-dgi daniel-dgi changed the title update karaf to 4.0.2 update karaf to 4.0.3 Nov 2, 2015
@daniel-dgi
Copy link
Contributor

now it's 4.03 :D

@daniel-dgi
Copy link
Contributor

Heads up, this will break the basic image service because karaf 4's jetty component has issues with multipart/form-data. So we have two options: wait, or figure out a better services API :P

I say we should have a big long talk about our services API, and if we can do it differently. We could expose transactionality in Fedora and just have multiple calls within a transaction as opposed to accepting multipart/form-data. That is, open a transaction, ingest a basic image, add its OBJ, close transaction.

It may be best we take an approach like that. There's also the option of providing a single file for ingest/update, like a zipped bag or something.

@DiegoPino
Copy link
Contributor

@daniel-dgi, true. Let's figure it out (or start) during the Sprint. I'm still trying to understand what is missing in jetty9 to make multipart happen, if not a bug.

@ruebot ruebot assigned daniel-dgi and unassigned ruebot Nov 2, 2015
@ruebot
Copy link
Member Author

ruebot commented Nov 2, 2015

Sounds like a good topic for our Wednesday call! I'll add it to the agenda 😄

https://github.com/Islandora-Labs/islandora/wiki/November-4,-2015

@ruebot ruebot assigned whikloj and unassigned daniel-dgi and whikloj Nov 4, 2015
@daniel-dgi daniel-dgi self-assigned this Nov 9, 2015
@daniel-dgi
Copy link
Contributor

Ok, looks like if I throw in a JAXRS annotated interface into the collection and image services, we can hijack the route using camel-cxfrs. This will use karaf's internal jetty server (the one hawt is running on) instead of trying to have the camel context fire up its own. Will also give us more solid multipart support. Plus swagger :D

The intended use of something like this is to provide middleware services around cxf web services that are already defined in service beans. Ideally, I'd have more done in code in service beans or processors for a bit better code re-use. But that's out of scope for this issue. For now, this approach will get us what we need to upgrade to newer to unblock all the other issues that are waiting for this.

@ruebot
Copy link
Member Author

ruebot commented Nov 9, 2015

EXCELLENT.

@ruebot
Copy link
Member Author

ruebot commented Nov 23, 2015

Resolved with: fa60702

@ruebot ruebot closed this as completed Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants