Node has Parent context does not explicitly check if the field exists.

[bibliophileaxe]

What steps does it take to reproduce the issue?

• Add a context condition that gets triggered on Node has Parent.

• In Field that contains reference to parents select field_member_of

• Create a new content type.

• Add a content reference field with some other field name than field_member_of (field_node_reference, for example)

• Add new content of this type.

• Make sure the content reference field has a value.

• This results in a WSOD.

What happens?
WSOD

What did you expect to happen?
The content gets created

Which version of Islandora are you using?
2.0

Fix

islandora/src/Plugin/Condition/NodeHasParent.php

Line 141 in 3902cce

if ($entity->getEntityTypeID() == 'node' && $referenced_entity->getEntityTypeId() == 'node') {

Should check whether field exists.

Another small win:

islandora/src/IslandoraContextManager.php

Line 40 in 3902cce

if ($this->evaluateContextConditions($context, $provided) && !$context->disabled()) {

Disabled check should happen before the evaluation of context conditions.

Screenshots: