-
Notifications
You must be signed in to change notification settings - Fork 742
Fixed some formatting errors from detekt. #2842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Fix the CI errors and we can merge ✅
Detekt Errors to fix:
|
Sure on it |
@ILIYANGERMANOV Can you please help me out in this issue when script tries to run
|
No idea, works on my machine 😀 Jk, what OS are you using? |
windows |
Should I go for the manual process of updating the baseline.yml file?🥲 |
Please do so, no idea how to fix it. You can ChatGPT to fix the script on Windows |
Okay |
Somehow fixed the detekt baseline🥲 |
Nice 🎉 400+ files changed, I see that Detekt made some auto-format. Updated the branch and merging after the CI pass of up-to-date main. Great job! |
Thanks 🤞 |
* Fixed some formatting errors from detekt. * Add Detekt baseline * Final changes push --------- Co-authored-by: Iliyan Germanov <[email protected]>
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.What's changed?
Describe with a few bullets what's new:
ivy.wallet.video.mp4
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Troubleshooting CI failures
If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.
Detekt
Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.
To run Detekt locally:
If the Detekt errors are caused by a legacy code, you can suppress them using a basline.
Detekt baseline (not recommended)
Lint
We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.
To run Lint locally:
If the Lint errors are caused by a legacy code, you can suppress them using a basline.
Lint baseline (not recommended)
Unit tests
If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.
To run the Unit tests locally: