Fix issue 2869

[beradeep]

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

• The PR is submitted to the main branch.
• I've read the Contribution Guidelines and my PR doesn't break the "Contributing Rules".
• I've read the Architecture Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• 🎬 I've attached a screen recoding of the changes.

What's changed?

Describe with a few bullets what's new:

• added date feature to loans
• configured its editability
• updated db from v123-v124 using proper migration

Does this PR closes any GitHub Issues?

• Closes Loans' missing date #2869

[ILIYANGERMANOV]

Didn't review much in detail but LGTM! A few things before being ready to merge:

• We need ✅ on all CI checks. If the Detekt errors are caused by the legacy code and too much, you can a Detekt baseline.
• Fix the unused imports Detekt problems
• I'll test the DB migration when the APK is ready.

Nice work 💯

[nvllz]

Hi @beradeep. This PR seems to break the ability to import backups from older versions of the app, as I can't import a backup from the latest stable release. When I tried importing to the version with the commit rolled back, it worked fine.

Note: I have loan entries in my backup, so it may be a matter of not handling loans without dates on import.

[ILIYANGERMANOV]

Hey @beradeep it's probably something with the date - can you make a bugfix PR? Thanks for reporting @nvllz!! 🙏 Great catch

[beradeep]

Sure, I'll look into it. Thanks for the report @nvllz.

[ILIYANGERMANOV]

Hey @beradeep the fix is to:

• make the Loan datetime nullable for backwards compatibility
• write some export & import logic in the BackupLogic.kt so this date can be backed up, too