-
Notifications
You must be signed in to change notification settings - Fork 29
Performance issue IE11/Edge #25
Comments
I think this is more of a general CodeMirror issue than I have a hunch that the gutters are what's slowing everything down. Removing the gutter seems to have a big impact on performance. Turning on line wrapping also seems to help a lot. |
Out of curiosity, are you setting |
No i do have a fix height I'm playing a bit right now, and yeah Thank you for helping me, even if it is not related to your addon. |
I figured out that the something like that: _allCodeMirrorOptions: {
theme: 't17-dark',
tabSize: 4,
lineNumbers: true,
lineWrapping: true,
},
_codeMirrorOptionsSlowBrowsers: {
mode: 'default',
},
_codeMirrorOptionsFastBrowsers: {
mode: 'htmlmixed',
matchTags: { bothTags: true },
autoCloseTags: true,
autoCloseBrackets: true,
autoClearEmptyLines: true,
},
codeMirrorOptions: Ember.computed({
get() {
let options = this.get('_allCodeMirrorOptions');
if (bowser.msie || bowser.msedge) {
options = Ember.merge(options, this.get('_codeMirrorOptionsSlowBrowsers'));
} else {
options = Ember.merge(options, this.get('_codeMirrorOptionsFastBrowsers'));
}
return options;
}
}).readOnly(), I'm not proud about this solution but it's the only "solution" that works for me. If someone has a better solution please let me know! |
Hey,
i do have IE11 and Edge performance issue on everything especially after scrolling. Am i alone with this issue? I have no idea whats the problem first i thought the problem is because embers vendor.js is allways huge but after testing a bit it doesn't change nothing if i load the js-files externally.
CodeMirror it self handle IE and Edge great, on your demo-site it does work pretty well. But on my real-world app it does not work great on IE/Edge i have loaded following modes:
modes: ['xml', 'css', 'javascript', 'htmlmixed']
and following options:
codeMirrorOptions: { lineNumbers: true, matchTags: { bothTags: true }, mode: 'htmlmixed', tabSize: 4, theme: 't17-dark', foldGutter: true, gutters: ['CodeMirror-linenumbers', 'CodeMirror-foldgutter'], autoCloseTags: true, autoCloseBrackets: true, autoClearEmptyLines: true, styleActiveLine: true, }
and inserted a html with > 1000 lines of code (thats what i need).
Any solutions?
The text was updated successfully, but these errors were encountered: