Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Sphere and Sphere SDDR post-processing is currently broken #231

Closed
dodu94 opened this issue Feb 20, 2024 · 2 comments
Closed

[BUG] - Sphere and Sphere SDDR post-processing is currently broken #231

dodu94 opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dodu94
Copy link
Member

dodu94 commented Feb 20, 2024

Describe the bug
Sphere and Sphere SDDR benchmarks post-processing for comparison is currently broken. One reason is probably the different behaviour of pandas across different python releases. There may be other additional issues though

To Reproduce
compare two different libraries on the Sphere benchmark

Expected behavior
post-processing should end gracefully

Desktop (please complete the following information):

  • OS: Linux
  • Version: Linux branch
  • Python version 3.7
@alexvalentine94
Copy link
Collaborator

Sphere single now restored as well as comparison cases (see #255 ). Sphere SDDR also now includes full original functionality. Example outputs from Linux branch:

Image

Image

Image

@alexvalentine94
Copy link
Collaborator

Examples from SphereSDDR also now restored. Atlas (now Word only) also replicates previous behavior - example below is for sphere leakage. Also included is new sheet added for reporting number of standard deviations from the mean of reference library.

Image

Image

Image

Image

@github-project-automation github-project-automation bot moved this from In progress to Done in v3.0.0 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants