Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation function #66

Closed
Radiation-Transport opened this issue Jun 19, 2020 · 3 comments
Closed

translation function #66

Radiation-Transport opened this issue Jun 19, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@Radiation-Transport
Copy link
Collaborator

The translating function to FENDL3.1c is generating mcard with some isotopes which are not in the XS.
See next example, also attached MaterialTS.txt

image

image

@Radiation-Transport Radiation-Transport added the bug Something isn't working label Jun 19, 2020
@dodu94
Copy link
Member

dodu94 commented Jun 19, 2020

I will look into it

@dodu94
Copy link
Member

dodu94 commented Jun 19, 2020

This is due to a logical mistake in the conversion of natural zaids. Indeed, if a correspondant natural zaid is not found in the requested library, an expansion is effectuated. Unfortunately the expansion is done without checking if every single zaid that is in the list of natural abundances is actually present in the library. A check of this type must be introduced whith some sort of redistribution of the missing precentage of the unavailable zaid(s) over the available ones.

@dodu94 dodu94 added this to the v0.5.1 milestone Jun 26, 2020
@dodu94
Copy link
Member

dodu94 commented Jun 26, 2020

The bug has been fixed as follow:

  • now the availability of each zaid that compose the natural expansion is verified
  • in case it is not available the availability in the default library is verified

If the zaid is not available even in the default library the conversion triggers the same error (and consequent error handling) of no possible translation with warnings both in cmd and log file. If this behaviour turns to be too harsh through user experience feedback, softer handling could be considered in the future (The extreme rarity of this chain of events should also be kept in mind). For the moment being the issue is closed

@dodu94 dodu94 closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants